Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add details for content of *_beh.json #902

Merged
merged 7 commits into from
Nov 10, 2021
Merged

[ENH] add details for content of *_beh.json #902

merged 7 commits into from
Nov 10, 2021

Conversation

Remi-Gau
Copy link
Collaborator

Add more info and an example concerning for beh.tsv an beh.json

Related to this issue in the BIDS validator:
https://github.com/bids-standard/bids-validator/issues/1364

@Remi-Gau @tsalo
Apply suggestions from code review
a8bae43 
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
sappelhoff
sappelhoff reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from my suggestions and some markdown style issues (see linter), this LGTM! thanks Remi :-)

Remi-Gau and others added 2 commits October 21, 2021 12:04
@Remi-Gau @sappelhoff
Apply suggestions from code review
4b1a6c0 
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@sappelhoff
Update 07-behavioral-experiments.md
c4f8be7
@sappelhoff
Copy link
Member

CI issue in codespell is already "fixed" --> I renamed the PR that contained the typo, so running the auto-changelog generator on "master" next time will fix the changelog.

@Remi-Gau Remi-Gau mentioned this pull request Oct 27, 2021
Merged
@Remi-Gau
Copy link
Collaborator Author

Thanks for fixing my makdown. 😄 🤗

@sappelhoff sappelhoff requested a review from tsalo October 27, 2021 15:22
tsalo
tsalo approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sappelhoff sappelhoff merged commit 4d5a2f6 into bids-standard:master Nov 10, 2021
@sappelhoff
Copy link
Member

Thanks for this 👍

@Remi-Gau Remi-Gau deleted the beh_json branch November 15, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Remi-Gau @sappelhoff @tsalo